From ffd8ac60f79865a4c7191be80aa3152dc052394e Mon Sep 17 00:00:00 2001
From: Eric Callahan <arksine.code@gmail.com>
Date: Fri, 24 Feb 2023 11:00:29 -0500
Subject: [PATCH] flash_can: reduce error output

Don't log read exceptions for each iteration, only log when the
exception differs.  Log timeout exceptions separately.

Signed-off-by:  Eric Callahan <arksine.code@gmail.com>
---
 scripts/flash_can.py | 13 ++++++++++---
 1 file changed, 10 insertions(+), 3 deletions(-)

diff --git a/scripts/flash_can.py b/scripts/flash_can.py
index 5cd23fe..6f164bd 100755
--- a/scripts/flash_can.py
+++ b/scripts/flash_can.py
@@ -127,6 +127,7 @@ class CanFlasher:
         crc = crc16_ccitt(out_cmd[2:])
         out_cmd.extend(struct.pack("<H", crc))
         out_cmd.extend(CMD_TRAILER)
+        err = Exception()
         while tries:
             data = bytearray()
             recd_len = 0
@@ -143,9 +144,15 @@ class CanFlasher:
                         recd_len = data[3] * 4
                         read_done = len(data) == recd_len + 8
                         break
-
-            except Exception:
-                logging.exception("Can Read Error")
+            except asyncio.TimeoutError:
+                logging.info(
+                    f"Response for command {cmdname} timed out, "
+                    f"{tries - 1} tries remaining"
+                )
+            except Exception as e:
+                if type(e) != type(err) or str(e) != str(err):
+                    err = e
+                    logging.exception("Can Read Error")
             else:
                 trailer = data[-2:]
                 recd_crc, = struct.unpack("<H", data[-4:-2])